tedious icon indicating copy to clipboard operation
tedious copied to clipboard

Published 20 hours ago • verified publisher icon tediousjs

Added timezoneOffset prop to readDateTimeOffset

Open nibblesnbits opened this issue 5 years ago • 4 comments

Returning this will allow consuming libraries to provide accurate timezone information. Addresses #1107.

nibblesnbits avatar Jun 10 '20 06:06 nibblesnbits

I don't know what this failure in Travis means. Any guidance there?

nibblesnbits avatar Jun 10 '20 08:06 nibblesnbits

@nibblesnbits Sorry for the trouble you're facing.

We're following Conventional Commits for commit messages, which allows us to have the release process fully automated. 🙇‍♂️

The Travis failure is mostly a reminder for maintainers to squash your commits / change the commit messages before merging.

arthurschreiber avatar Jun 10 '20 09:06 arthurschreiber

On another note, would you mind adding a test case for this new property? 🙇‍♂️

arthurschreiber avatar Jun 10 '20 09:06 arthurschreiber

On another note, would you mind adding a test case for this new property? 🙇‍♂️

Actually, I see no existing tests that address the functions in the value-parser.ts file directly. Could you provide some guidance on what would qualify as a valid test for readDateTimeOffset?

nibblesnbits avatar Jun 11 '20 18:06 nibblesnbits