android-architecture-course icon indicating copy to clipboard operation
android-architecture-course copied to clipboard

Published 20 hours ago • verified publisher icon techyourchance

Upgrade project for the latest gradle

Open romanbsd opened this issue 5 years ago • 2 comments

  1. Update gradle and gradle plugin
  2. Update dependencies
  3. Migrate to AndroidX
  4. Use https for stackoverflow API

romanbsd avatar Nov 12 '20 10:11 romanbsd

Hello Roman, Thank you for this PR. I really appreciate the fact that you took time to submit it. Unfortunately, I can't accept it right now. Allow me to explain why. As you probably know, this is a tutorial project for a video course. In that course I show step-by-step development and enhancement of this application and also invite students to solve exercisees and participate in this process. Therefore, the students will be resetting git history and writing the code against earlier commits. If I accept this PR, then the end state of the app will use different set of dependencies than the intermediate commits. I suspect that this might be very confusing to less expereinced developers, so I don't want to take risks. Once again, thank you for submitting this PR. I'll leave it open for now as a reminder for me.

techyourchance avatar Nov 17 '20 07:11 techyourchance

Perhaps create a branch which will hold these changes for people who want to adopt the code in their projects after seeing the course.

romanbsd avatar Nov 17 '20 10:11 romanbsd