quill
quill copied to clipboard
Changing registration/confirmation deadlines
Changing registration / confirmation deadlines when users are in the middle of the pipeline doesn't seem to have a defined behavior. We commonly need to extend deadlines for individual cases, but their dashboards don't update, acceptances get canceled, etc.
I think I ran through this issue in our system. If I remember correctly, the temporary fix was to update the "status.confirmBy" field for all users directly in the mongo shell.
Updating the confirmation deadline on the admin dashboard calls this route, which calls SettingsController.updateField(timeConfirm, time_in_ms, callback). User.confirmBy isn't updated.
Possible fixes:
- Change confirmBy references (e.g. this, this) to use the global settings confirmation time
- Update confirmBy for every user in app/server/routes/api.js
Preferences? cc @jlin816
As some background, I wrote this to not set all users confirmation dates to allow for different sets of users (waves) to have different confirmation times. This is intended behavior - after changing the confirmation time, any users that are accepted afterwards then take on the value set.
Thus, to extend a single person's confirmation, one would set the new confirmation date and then re-accept that user.
This behavior is totally not obvious and isn't explained, but was my intention. This seemed like an adequate solution at the time (vs creating an additional UI for acceptances). I'd be happy to chat more about why things are the things they are, and it'd be great if you guys could add these new features.
It would actually be great to create additional features that I didn't originally have time for, like:
- an acceptance UI that takes a list of email addresses and allows setting of confirmation time for that batch
- a UI on each user that allows admin to set new confirmation times, change state, etc.
For this case, I don't think it's a good idea to have a globally configurable confirmation date that automatically applies for every user, but I understand if you disagree.