Backbone-Responsive-CSS3-Page-Transitions icon indicating copy to clipboard operation
Backbone-Responsive-CSS3-Page-Transitions copied to clipboard

Published 20 hours ago • verified publisher icon techjacker

Always uses default transition when using pushstate

Open digitalgears opened this issue 12 years ago • 3 comments
trafficstars

When calculating the transition direction, the plugin always assumes url's are a hash. This means when using pushstate, the default transition always runs (i.e. no transition).

I suggest two new options are needed 'pushstate': true|false, 'appRoot': '/'

digitalgears avatar Jul 08 '13 11:07 digitalgears

I wasn't aware of this, thanks for letting me know.

I'll put it on the to do list. Although I haven't got much free time at the moment so it might take a while to get released in case you were relying on this urgently.

techjacker avatar Jul 08 '13 15:07 techjacker

No rush, just thought I'd bring to your attention. I have managed to work round it by just parsing in the direction.

There are also a few other things like the use of $.browser which has been deprecated in 1.9. I also made some changes to the way the container height gets calculated in case you only want to transition a small part of the page. It's probably a little to custom to warrant a pull request though.

Its a cool plugin btw :-)

digitalgears avatar Jul 08 '13 15:07 digitalgears

Cheers dude, if you fork and push those changes you mentioned then I'll try and get those in as well.

techjacker avatar Jul 09 '13 15:07 techjacker