DMS-Backend icon indicating copy to clipboard operation
DMS-Backend copied to clipboard

merge: (#844) 투표 결과 조회 쿼리 모범학생, 학생 분리 및 관련된 기능 전체 수정

Open ryujaemin08 opened this issue 7 months ago • 2 comments

작업 내용 설명

  • 투표결과 조회 쿼리 모범학생, 학생투표로 분리함
  • 기존에 "임시" 로 되어있던 투표 결과 공지로 보내는 기능을 실제 투표 결과로 보내게 수정
  • QueryVotesUseCase 에서 보내는 투표결과를 모범학생, 학생으로 분리해서 결과 가져오게 함.
  • votePersistenceAdapter 에서 JPA 표현식을 사용하여 최대한 queryDSL 코드를 분리함

주요 변경 사항

  • QueryVoteUseCase
  • VotePersistenceAdapter
  • CommandNoticeServiceImpl

결과물

체크리스트

  • [x] 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • [ ] 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • [ ] 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

  • resolved #844

ryujaemin08 avatar Apr 08 '25 23:04 ryujaemin08

현재 코드가 너무 길고 가독성이 엄청나게 떨어집니다

주요 로직들을 메서드별로 분리하거나 추상화 시키는게 어떨까요?

ilyoil2 avatar Apr 11 '25 00:04 ilyoil2

Codecov Report

Attention: Patch coverage is 0% with 87 lines in your changes missing coverage. Please review.

Project coverage is 3.03%. Comparing base (fbd3bb2) to head (d120a4d). Report is 18 commits behind head on develop.

Files with missing lines Patch % Lines
...ens/dms/persistence/vote/VotePersistenceAdapter.kt 0.00% 41 Missing :warning:
.../domain/notice/service/CommandNoticeServiceImpl.kt 0.00% 38 Missing :warning:
...liens/dms/domain/vote/usecase/QueryVotesUseCase.kt 0.00% 6 Missing :warning:
...iens/dms/domain/vote/service/GetVoteServiceImpl.kt 0.00% 1 Missing :warning:
...ms/domain/vote/usecase/UpdateVotingTopicUseCase.kt 0.00% 1 Missing :warning:
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             develop    #873      +/-   ##
============================================
- Coverage       3.06%   3.03%   -0.04%     
  Complexity        90      90              
============================================
  Files            713     715       +2     
  Lines          10122   10231     +109     
  Branches         230     237       +7     
============================================
  Hits             310     310              
- Misses          9802    9911     +109     
  Partials          10      10              
Files with missing lines Coverage Δ
...iens/dms/domain/vote/service/GetVoteServiceImpl.kt 0.00% <0.00%> (ø)
...ms/domain/vote/usecase/UpdateVotingTopicUseCase.kt 0.00% <0.00%> (ø)
...liens/dms/domain/vote/usecase/QueryVotesUseCase.kt 0.00% <0.00%> (ø)
.../domain/notice/service/CommandNoticeServiceImpl.kt 0.00% <0.00%> (ø)
...ens/dms/persistence/vote/VotePersistenceAdapter.kt 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d7ea0d...d120a4d. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Apr 11 '25 00:04 codecov-commenter