Tom Dyas

Results 211 comments of Tom Dyas

Note: This PR is stacked on top of https://github.com/pantsbuild/pants/pull/22352 which refactors environments-related code to avoid an import cycle which this PR would encounter otherwise.

Is it relevant that `packaging.requirements.Requirement` (used by `interpreter_constraints.py`) does not compare against prerelease versions by default? That is, the code may need to set `req.specifier.prereleases = True` to accept prerelease...

> @tdyas I noticed you self-requested a review, are you still planning to take a look? Yes. I just approved the CI run, so will likely approve if no issues...

Does https://github.com/docker/setup-docker-action need to be upgraded (redirected from https://github.com/crazy-max/ghaction-setup-docker so we should update the name in any event)?

There is some code linked from the rustls issue that may solve the issue by supplying a custom certificate verification step to rustls. https://github.com/paritytech/x509-signature/issues/4#issuecomment-691729509

You can enable trace level logging for rustls and see if that gets more out of the logging. Try adding `--log-levels-by-target='{"rustls": "trace"}'` to your invocation. I believe specifying "rustls" will...

`rustls` uses the `webpki` crate to verify certificates. `webpki` has an open issue that appears to be on point entitled "During parsing, accept v1 certificates and allow certificates without subjectAltName":...

How would this interact with the Go plugin where we probably want an address referring to a directory to reference the `go_package` in that directory? (In some sense, this aligns...

Would it make sense to have "directory specs" use some form of inference rule to decide on what target to use? Specifically, certain _target types_ could be opted in by...

> Imo, we can't expect the lay user to memorize rules for how each target type maps to particular Pants semantics for addressing. To clarify, the idea was proposing essentially...