jdeb
jdeb copied to clipboard
Snapshot version isn't expanded when <deb> is specified
Using the Maven plugin and jdeb 1.9, the snapshot version isn't expanded when the name of the file is overriden by specifying the <deb> element in the plugin configuration.
For example with:
<deb>${build.directory}/foo_${version}_all.deb</deb>
<snapshotExpand>true</snapshotExpand>
the file generated is foo_1.0-SNAPSHOT_all.deb.
I believe the format should be:
<deb>[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]</deb>
https://github.com/tcurdt/jdeb/blob/8b4b93b31320c33437f9e01c3e842d0adbfb24bf/src/main/java/org/vafer/jdeb/maven/DebMojo.java#L80-L86
Considering @luka-rol's comment, this issue could be "fixed" by tweaking the documentation to reflect the proper format of the variables. Either way, the ${buildDirectory} variable referenced in the current docs is not resolved properly, so at least that one needs fixing.
I can submit a pull request if you think a doc update is enough.
If this solves it, I would probably consider it just a documentation fix.
<deb>[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]</deb>
<snapshotExpand>true</snapshotExpand>
If this solves it, I would probably consider it just a documentation fix.
<deb>[[buildDir]]/[[artifactId]]_[[version]]_all.[[extension]]</deb> <snapshotExpand>true</snapshotExpand>
It does, I tested it manually. I just submitted a pull request.