Torsten Curdt

Results 574 comments of Torsten Curdt

Looking good and merged. For a release it still needs fixes for Windows though it seems. https://ci.appveyor.com/project/tcurdt/jdependency/builds/48559371

@parnmatt should have been released with jdependency-2.10 about a year ago

And it's in the pom on master https://github.com/apache/maven-shade-plugin/blob/master/pom.xml#L172

@nlewo IMO you are worrying a little to much about possible future incompatibilities. I think everyone is aware that things can change. As long as they are documented and versioned...

So if I see it correctly we need a way to configure it https://github.com/nlewo/comin/blob/main/internal/config/config.go And the we would need to hook it up at the end of the deployment loop...

> I think it would be better to run the script just after calling the `deployFunc` and before locking the `deployer` Can you explain why? To me it seems more...

Actually on a second look all that information seem to be available further up, too.

Shall I prepare a PR? @nlewo

Before I continue some guidance would be good: https://github.com/nlewo/comin/compare/main...tcurdt:comin:post-deploy-command 1. I am not sure how to get access to the config from inside the `Deployer` 2. It feels more natural...

@nlewo ping ... any thoughts?