fix: return exit code 1 when dead links found

[kt3k]

The CLI used to return exit code 1 when dead links found until version 3.12.2, but it changed to exit code 0 in this commit (This seems unintentional as the behavior change not mentioned)

This PR change the exit code back to the original (1) when there are dead links.

[BaseMax]

cc @dudeofawesome cc @tcort

https://github.com/tcort/markdown-link-check/commit/d8f522b10d74b55e93a4677b9f1b9f0f314e94d6

[mieubrisse]

Hey folks, I'm also struggling with this regression where it returns 0 even when dead links are found. It seems like the failing tests have to do with the return code:

@kt3k any clue if this is related to your change?

[kt3k]

pushed a potential fix https://github.com/tcort/markdown-link-check/pull/452/commits/f55187526ba5369d5864cee33f8b663706c336f1

[mieubrisse]

Thanks a ton @kt3k !

@WillGibson can we get the workflows run to see if this fixed the CI?

[smainil]

@kt3k any chance you can fix the tests ?

[kt3k]

Hey, sorry for the delay. I updated the test cases to pass them on windows. Please run the CI again

(Note: I experimented the windows run in https://github.com/kt3k/markdown-link-check-clone/pull/1 )

[MikeMcC399]

This is a critical fix, restoring functionality that makes markdown-link-check usable once again in unattended CI workflows.

Please review with priority and merge!

cc: @tcort @WillGibson @BaseMax @smainil

[MikeMcC399]

@tcort

You've cut a new release v3.14.0, however the critical fix in this PR was not merged and included.

Until this issue is fixed, markdown-link-check remains of very limited value in unattended CI workflows, since it always returns success, thus failing its primary duty of reporting link errors to the calling process if it finds any link errors.

Please take a look here and see if you could merge this PR soon and cut a new patch release to follow on from v3.14.0.

[tcort]

merged + published in v3.14.1

[MikeMcC399]

@tcort - Thank you! Installed and now working perfectly again!