markdown-link-check icon indicating copy to clipboard operation
markdown-link-check copied to clipboard

gaurav-nelson/github-action-markdown-link-check is no longer maintained

Open WillGibson opened this issue 8 months ago • 10 comments

@tcort @smainil @BaseMax

Options include:

  • Fork it and maintain a tcort action to go with the checker
  • Ask @gaurav-nelson if they are happy for us to maintain it or transfer ownership
  • Evaluate Linkspector and consider whether we want to continue to support markdown-link-check or provide instructions for moving over.

Based on my initial tests the third one is not an option just yet, but it may be worth considering the benefits of joining forces on a single tool.

Thoughts?

WillGibson avatar Apr 09 '25 10:04 WillGibson

If we want people to continue using markdown-link-check, I think we should provide our own github action.

I don't know if linkspector is better or not / what's the differences

smainil avatar Apr 10 '25 06:04 smainil

Let's fork it.

Makes sense for it to live with the other repositories I think.

@tcort, please could you fork gaurav-nelson/github-action-markdown-link-check and add the rest of us as maintainers and I'll take it from there.

WillGibson avatar Apr 13 '25 09:04 WillGibson

Let's fork it.

Makes sense for it to live with the other repositories I think.

@tcort, please could you fork gaurav-nelson/github-action-markdown-link-check and add the rest of us as maintainers and I'll take it from there.

Done! https://github.com/tcort/github-action-markdown-link-check

tcort avatar Apr 13 '25 10:04 tcort

I don't have any issues. I'll add the link to this action in gaurav-nelson/github-action-markdown-link-check and archive that repository. Thank you @tcort @WillGibson @smainil

gaurav-nelson avatar Apr 15 '25 00:04 gaurav-nelson

@tcort Can I get access to the settings for the new repository to set up branch protection, default to squash merge etc.?

WillGibson avatar May 07 '25 05:05 WillGibson

I think I will want to detach the fork too, so that pull requests don't default to being made to @gaurav-nelson's repository.

WillGibson avatar May 07 '25 05:05 WillGibson

FYI: the new github action was tagged with 1.1.0 instead of v1.1.0, so the docs are broken (they say to use tcort/github-action-markdown-link-check@v1, but it would have to be tcort/github-action-markdown-link-check@1 to be equivalent. I suggest re-releasing as v1.1.0 to keep consistent with how most github actions does it.

(I wrote this here, because issues are not enabled on the github action repo)

gjermundgaraba avatar May 12 '25 14:05 gjermundgaraba

Thanks @gjermundgaraba for checking the text and your recent PR.

BaseMax avatar May 12 '25 14:05 BaseMax

Good point @gjermundgaraba. I will do a new release.

WillGibson avatar May 13 '25 07:05 WillGibson

Done. Released as v1.1.0 and v1, Readme updated.

WillGibson avatar May 13 '25 11:05 WillGibson

This issue has been marked as stale because it has been open 60 days with no activity. It will be closed in 30 days unless the stale label is removed or someone adds a comment.

github-actions[bot] avatar Jul 13 '25 08:07 github-actions[bot]