Adafruit-GFX-Font-Customiser icon indicating copy to clipboard operation
Adafruit-GFX-Font-Customiser copied to clipboard

show attribute value in button

Open RBasile opened this issue 1 year ago • 2 comments

Having the value visible is useful to verify that a monospaced font has the same attribute for every character or when creating a new character to be able to set up them quickly without having to count the squares

the value in the button calculated when the font is extracted and updated when press + or -

It looks like that: image

RBasile avatar Jan 24 '24 20:01 RBasile

Hi @RBasile and thanks for your contribution!

Small nits:

  • could you expand (in the issue desc) on the rationale of having the (rather technical) value directly in the UI? A PR with no description whatsoever is a bit dry tbh
  • would you mind adding a space after the colon for clarity and readability (in all buttons)?

Thanks

tchapi avatar Jan 24 '24 23:01 tchapi

Thanks for the tips ( it's my first pull request ) I made the change, is it ok ?

RBasile avatar Jan 27 '24 09:01 RBasile

All good, thanks!

tchapi avatar Feb 03 '24 17:02 tchapi