Thomas Broyer

Results 214 comments of Thomas Broyer

> Is there a way to externally tell / configure Annotation processor to be run in one of these sandbox/isolation modes and see if processor works before actually augmenting annotation...

Fwiw, Dagger is going to use something similar: https://github.com/google/dagger/issues/1120#issuecomment-417034642

Apparently, more changes are needed for incremental processing to actually work: with `./gradlew compileJava --info` on my project, I got: ``` Full recompilation is required because the generated type 'xxx.xxx.ImmutableXxx'...

In `Filer`'s `createSourceFile`.

Note that for incremental annotation processing, there needs to be exactly one originating element, i.e. (IIUC) the `@Value.Enclosing` when it exists, and not its inner `@Value.Immutable` types.

Unfortunately, it looks like some more work would be needed (it at all possible): > Full recompilation is required because incremental annotation processors are not allowed to read resources. Analysis...

Hey looks like this restriction has been removed in Gradle 5.0 (and I was testing with 4.10): https://github.com/gradle/gradle/commit/8ce7ea59c0b47e2dc6f090c923b9c893979095f0 Will retest with 5.0 and let you know.

So, I tried 2.7.4 with Gradle 5.0 and compile is incremental :tada: Now, I have another problem though, but this is on Gradle and/or JDK side, not Immutables (when I...

In the repro case attached to gradle/gradle#8128, the first run (full compilation) is basically equivalent to: ``` javac -cp value-annotations-2.7.4.jar -processorpath value-2.7.4.jar -d build/classes/java/main -Aimmutables.gradle.incremental src/main/java/reprocase/Main.java src/main/java/reprocase/SomeValue.java ``` when changing...

But then what if the change to `Main.java` is to add `@Value.Immutable`? :wink: