tauri-docs icon indicating copy to clipboard operation
tauri-docs copied to clipboard

docs(features): update `upload.mdx`

Open dreyfus92 opened this issue 1 year ago • 7 comments

What kind of changes does this PR include?

  • New or updated content

Description

  • Closes #1494
  • What does this PR change? Give us a brief description. Updates /features/upload page

[!NOTE] WIP Still checking details of the plugin.

dreyfus92 avatar Mar 05 '24 21:03 dreyfus92

Deploy Preview for tauri-docs-starlight ready!

Built without sensitive environment variables

Name Link
Latest commit 6753978304455e765c0369f09f0a884066666998
Latest deploy log https://app.netlify.com/sites/tauri-docs-starlight/deploys/65f5ca9b904ddf000831c1ac
Deploy Preview https://deploy-preview-1924--tauri-docs-starlight.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 05 '24 21:03 netlify[bot]

ah damn, that's my bad. @amrbashir We still want to merge it into the http plugin right?

FabianLars avatar Mar 06 '24 08:03 FabianLars

I think it is fine to keep as is (or removed) since a combination of http + fs plugins can achieve the same thing?

I am a bit hesitated to merge into http plugin because we will need to handle scope for the filesystem as well and also upload plugin have a bit more dependencies that may not concern most users using http plugin.

amrbashir avatar Mar 06 '24 13:03 amrbashir

a combination of http + fs plugins can achieve the same thing?

That'd be much slower because the data would have to go through the ipc. The v2 ipc may be faster, but not that much faster :/

also upload plugin have a bit more dependencies that may not concern most users using http plugin.

imo feature flags would be fine for that 🤷

because we will need to handle scope for the filesystem as well

Hmm, that's indeed annoying and a good reason...

FabianLars avatar Mar 06 '24 14:03 FabianLars

I guess better to be kept as a standalone plugin

amrbashir avatar Mar 06 '24 17:03 amrbashir

should we rename it to http-extra? 😂 (not actually meant as a joke, i don't like the upload name when it can download too)

FabianLars avatar Mar 06 '24 17:03 FabianLars

sure, whatever sounds right with you

amrbashir avatar Mar 06 '24 17:03 amrbashir

@FabianLars, so should I close this?

dreyfus92 avatar Mar 07 '24 20:03 dreyfus92

No, seems like we keep the plugin. If we indeed rename it then we can just change the docs 🤷

FabianLars avatar Mar 07 '24 20:03 FabianLars