Andrew Tatomyr

Results 315 comments of Andrew Tatomyr

Related: https://github.com/Redocly/redocly-cli/issues/1397.

Hi @matthias-m-fadi, This is a bug indeed. Thank you for reporting the issue!

Hi @matthias-m-fadi! Have you tried adding the mapping to the discriminator as the error message suggests? The error seems to be gone once I've added the mapping: ```yaml discriminator: propertyName:...

Hi @jeremyfiel, Thanks for the idea. However, we use our fork of AJV with various fixes and improvements. Also, AJV is considered to be the fastest JSONSchema validator out there,...

> Should this be a minor change instead of a patch? Should I create two separate changeset files? Please use minor (replace the existing one).

@adamaltman perhaps we decided this is more of an improvement rather than a fix. I donโ€™t recall the exact reason though. @IgorKarpiuk could you take a look and finalise this...

@jedelson-pagerduty do you have any updates on this? FYI we've recently moved the `remove-unused-components` decorator, so that's why this MR got the conflicts ๐Ÿ˜….

@jedelson-pagerduty I believe those changes mirror this rule: https://github.com/Redocly/redocly-cli/blob/572980cb33e3ff399e035246e8aa2c24e54d9617/packages/core/src/rules/oas3/no-unused-components.ts#L43 Looks like this is a workaround to detect discriminators.

I haven't found any related tests that can shed some light on what was the case for this ๐Ÿ˜„. @RomanHotsiy could you maybe help with an example of a false...

Thanks for reporting @vip32! I believe this is specific to Windows command line. We will check if it could be fixed a bit later. Meanwhile, as a workaround, you can...