taskiq-nats icon indicating copy to clipboard operation
taskiq-nats copied to clipboard

Added NATS Result Backend

Open chandr-andr opened this issue 1 year ago • 4 comments

chandr-andr avatar Mar 24 '24 20:03 chandr-andr

Codecov Report

Attention: Patch coverage is 98.24561% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.59%. Comparing base (5a5b300) to head (7d4c3e8). Report is 19 commits behind head on develop.

Files Patch % Lines
taskiq_nats/result_backend.py 98.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #13      +/-   ##
===========================================
+ Coverage    98.33%   98.59%   +0.25%     
===========================================
  Files            2        4       +2     
  Lines           60      142      +82     
===========================================
+ Hits            59      140      +81     
- Misses           1        2       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 24 '24 20:03 codecov-commenter

what is the status of this PR? I just came across taskiq-python module and wanted to use it with nats. However, was surprised to find that it required redis for results storage. I would prefer to use one system like nats (since it already supports key-value store) and not have to worry about maintaining two systems like nats and redis.

I hope this can PR can be merged soon and made part of official release. In the meantime, I will try it out locally to see if it works for my use case.

HemangLavana avatar Jul 03 '24 13:07 HemangLavana

@chandr-andr, can you please check this one?

s3rius avatar Jul 08 '24 16:07 s3rius

@s3rius It's waiting for you review)

chandr-andr avatar Jul 08 '24 16:07 chandr-andr