Jonas Bernoulli

> A minimal change (perhaps the way to go given nearing release) would be this: Sounds good to me. > The disadvantage is that it now allows `magit-apply`, which will...

> Magit should always specify --git-dir or GIT_DIR when cd-ing to a gitdir to run some Git subcommand. Magit is ***not*** cd-ing to a gitdir. 1. Magit calls `git commit`...

The problem is that `git` assumes that any `$GIT_EDITOR` is dumb. I.e., all that the editor does is open the file and once the user indicates that they are done,...

> I'm not sure where we are with this: is there a path forward? Currently your best option is to disable `global-git-commit-mode`. Disabling a global mode, which happens to be...

Or, we could just use the kludge that @kyleam posted way up in https://github.com/magit/magit/issues/5100#issuecomment-1962733424. > [#5074 (comment)](https://github.com/magit/magit/issues/5074#issuecomment-1879300770) has a workaround for the `.git/` case now fixed in the latest Git...

> I played around with the patch below a bit (not sure its changes are quite what you have in mind, but, at any rate, I think it captures the...

Thanks @kyleam. I've now tested those three cases too; still works. I've merged this now. To enable this workaround/feature users have to `(setq git-commit-cd-to-toplevel t)`.

@aikrahguzar Thanks for your feedback. I've adjusted the commit accordingly.

I've stuck to just `:value-type (repeat ... string)`.

Ups, forgot to push.