Mark Van de Vyver

Results 133 comments of Mark Van de Vyver

I suspect that adding [minicov](https://github.com/Amanieu/minicov) to the build stack could be required.

Thanks for taking the time to look at this @andylokandy. I'd like to understand some of the code a little better - is there a unit test that covers this...

OK, I'm a little confused. Are block expressions required by Minitrace or not?

> Not a bug. @zhongzc apologies for the unfocused report. I'm struggling to work out what is expected behavior and what is unexpected, and the 1different from three others suggested...

> Good question. I'd like to do so but I haven't come up with a solution. Ack these things are hard - as a great man once said "There are...

Thanks for the link. I like how @breeswish has delineated the scenarios, and I think that covers the scope. I think it'd be useful to iterate the design via actual...

> This seems like the only solution... But I'm not sure whether someone does want a single root span... @zhongzc What do you think? I'm still in the macro code,...

> I agree that we provide the same `max_level_*` and `release_max_level_*` like log. Hmm, I'm actually against implementing `max_level_*` and `release_max_level_*` like log, and I am only proposing/suggesting support for...

> I'm curious how minintrace could be used in an embedded environment which usually doesn't support allocation, not to mention the threading. Besides, since much effort on minitrace has been...

Just recording reasoning around hierarchy/precedence, more likely to arise when tracing a `mod`: ```rust #[trace("a", recurse=all)] pub fn outer() { defined_later(); defined_later_too(); #trace["b", recurse=false] fn defined_later_too() { println!("I'm traced with...