Thrift.jl icon indicating copy to clipboard operation
Thrift.jl copied to clipboard

HTTP Transport

Open tanmaykm opened this issue 7 years ago • 3 comments
trafficstars

It will be good to have an implementation of HTTP transport.

ref: https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/transport/THttpClient.cpp and https://people.apache.org/~thejas/thrift-0.9/javadoc/org/apache/thrift/transport/THttpClient.html

tanmaykm avatar Nov 12 '18 08:11 tanmaykm

Was just about to come by to ask about HTTP/HTTPS support. Unfortunately, I don't know C++, but I'm absolutely willing to help out by testing or whatever else as Thrift.jl is the cornerstone of OmniSci.jl

randyzwitch avatar Nov 19 '18 21:11 randyzwitch

At least in our case, this also requires TJSONProtocol to be implemented. Do you have an idea of which might be simpler to tackle? I've been getting better at C++, so I can probably read the Thrift code and translate to Julia with a bit of guidance

randyzwitch avatar Jul 10 '19 16:07 randyzwitch

The JSON protocol appears somewhat simpler to me. Happy to help along with whatever I can!

tanmaykm avatar Jul 25 '19 17:07 tanmaykm