go-web-app icon indicating copy to clipboard operation
go-web-app copied to clipboard

fix: websockets only work on port 8080

Open devhammed opened this issue 6 years ago • 5 comments
trafficstars

devhammed avatar Sep 07 '19 01:09 devhammed

Interesting. As I understand we will have two different HTML files – one for template and another is a "compiled" template.

The only thing I don't get is "production" mode. When I don't pass a port it turns into prod? not sure if it is a good idea.

I think I should add a command prod to run the app without WebSockets.

talentlessguy avatar Sep 10 '19 23:09 talentlessguy

The idea is when you run gwa build it means you are ready for production and Websockets will not be enabled. So this means Websockets only runs when using gwa dev and there will no be console error complaining of E_CONN_REFUSED since you don't actually need hot-reload again in production.

devhammed avatar Sep 11 '19 07:09 devhammed

@devhammed could ya pls fetch latest binary in your PR, and also describe how your gwa build, gwa dev and prod mode will work. And also pls rename template.html to dev.html if it is only for dev server.

Once you complete all these tasks I can merge

talentlessguy avatar Sep 13 '19 16:09 talentlessguy

Wow, it has been long 😏😏😏

devhammed avatar Apr 17 '20 13:04 devhammed

@devhammed I will merge once you describe it's usage here and complete other requirements

talentlessguy avatar Apr 17 '20 16:04 talentlessguy