modernize cln tests and CI

[daywalker90]

Replaces #255

I think in your PR tests ran slow because you were running them on an ancient pyln-testing version. Just to make sure i added VALGRIND=0 as that can cause huge slowdowns but i don't know when valgrind actually runs in these tests.

I also assume you don't want CI to run on anything else than commit to the master branch. While testing with a PR all CI ran both for the feature branch and the PR kinda weird.

Also developer: None is not needed with a modern pyln-testing version, as that is a default setting.

[daywalker90]

Ah yes thanks github for changing the default branch name.

[daywalker90]

@sr-gi clnrest and cln-grpc are just plugins to serve the rpc via REST and GRPC. They are not relevant for this project and can safely be ignored.

I removed the functions mentioning DEVELOPER. I'm not sure how they were still used, i could not find any code for them anymore.

Indeed allow_broken_log was removed in favor of broken_log which requires explicitly stating the expected broken log. Please check that the log lines i used are actually expected!

[daywalker90]

This works now, but the code needs to be properly formatted. Run black -l 120 watchtower-plugin/tests locally.

Looks good otherwise, thanks for taking the time to fix this!

done

This made me realize that there was a typo on this logline. Would you care changing it here and on the plugin side?

retier -> retrier

done

[sr-gi]

LGTM. Rust lint issues are unrelated.

Any additional comment @mariocynicys?