Thomas Kluyver

Results 1023 comments of Thomas Kluyver

Hi Asheesh! Good to hear from you again. :-) Yes, I think getting the source date from the most recent git commit sounds like a sensible thing to do. I'm...

Maybe. In principle, the filesystem timestamps still provide a kind of crude record if someone manages the master copy of the code on a single computer, with no version control....

Yup, I actually had to fix that recently for timestamps from SOURCE_DATE_EPOCH (#448).

Good point. I added the `ZipInfo.from_file` method while working on Flit, and I only found out about the 1980 limitation much more recently. So it makes sense that `from_file` doesn't...

Thanks, this is a good idea. Currently, the only parsing it does of that field is to validate that it matches the expected format: https://github.com/takluyver/flit/blob/7cd39b0747aa0689e02fd87359d08ad0232d69d1/flit/validate.py#L147-L151 #261 should also be solved...

Hi, that's basically expected - there's an alternative flag --pth-file which does the same as pip install -e. It's less elegant, but it works on windows. On Mon, 9 Mar...

Yep, that seems reasonable. I'll leave this open as a feature request.

@shuoli84 do you have specific examples of the kinds of problems you describe? Packaging C libraries as first class citizens is straying into becoming a general-purpose packaging system, which there...

We try to keep options to a minimum, so I'd say skipping the check is sufficient - and it will automatically skip it if you don't have an internet connection...

Yes, good point. That was originally written to create a flit-specific `flit.ini` file, and when I swapped over to `pyproject.toml`, basically no-one had the file already, so it was easy...