tailcall icon indicating copy to clipboard operation
tailcall copied to clipboard

fix: Enable JS build for all architecture

Open amitksingh1490 opened this issue 1 year ago • 9 comments
trafficstars

Issue Description:

We recently migrated from V8 to QuickJS for our JavaScript runtime. We initially utilized feature flags for disabling the build of JS features for architectures where V8 was incompatible.

Now, we aim to enable JS feature across all architectures.

Note: While this may potentially encounter issues on certain architectures, we should iteratively enable it for those where it works.

The expectation is to update the CI to build Tailcall on all supported platforms without any feature flags.

Additional Context:

  • Unsupported platforms

    • [ ] linux-x64-musl
    • [ ] linux-arm64-musl
    • [ ] linux-ia32-gnu
    • [ ] win32-x64-gnu
    • [ ] win32-arm64-msvc
    • [ ] win32-ia32-gnu
  • How it works on CI https://github.com/tailcallhq/tailcall/blob/dd2114deb7c939d44798b945f8491b1801678125/.github/workflows/ci.yml#L266

amitksingh1490 avatar May 06 '24 05:05 amitksingh1490

/bounty 180$

IMPORTANT: The bounty is priced at 30$ per platform. So in case only two platforms are supported we will pay only 60$.

tusharmath avatar May 13 '24 07:05 tusharmath

~~## 💎 $180 bounty • Tailcall Inc.~~

~~### Steps to solve:~~ ~~1. Start working: Comment /attempt #1869 with your implementation plan~~ ~~2. Submit work: Create a pull request including /claim #1869 in the PR body to claim the bounty~~ ~~3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts~~

~~🙏 Thank you for contributing to tailcallhq/tailcall!~~ ~~🧐 Checkout our guidelines before you get started.~~

Attempt Started (GMT+0) Solution
🔴 @feliciien May 13, 2024, 7:52:24 AM WIP
🔴 @ezhil56x May 13, 2024, 8:51:38 AM WIP
🟢 @varshith257 May 14, 2024, 9:16:28 PM #1963
🟢 @mehulmathur16 #1962
🟢 @ssddOnTop #2032

algora-pbc[bot] avatar May 13 '24 07:05 algora-pbc[bot]

/attempt #186

Algora profile Completed bounties Tech Active attempts Options
@feliciien 5 bounties from 1 project
MDX, Rust,
JavaScript & more
Cancel attempt

feliciien avatar May 13 '24 07:05 feliciien

/attempt #1869

Algora profile Completed bounties Tech Active attempts Options
@ezhil56x    5 tailcallhq bounties
+ 20 bounties from 9 projects
JavaScript, TypeScript,
Java & more
Cancel attempt

ezhil56x avatar May 13 '24 08:05 ezhil56x

[!NOTE] The user @feliciien is already attempting to complete issue #1869 and claim the bounty. We recommend checking in on @feliciien's progress, and potentially collaborating, before starting a new solution.

algora-pbc[bot] avatar May 13 '24 08:05 algora-pbc[bot]

@feliciien: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

algora-pbc[bot] avatar May 14 '24 07:05 algora-pbc[bot]

/attempt #1869

Options

varshith257 avatar May 14 '24 21:05 varshith257

💡 @varshith257 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

algora-pbc[bot] avatar May 14 '24 21:05 algora-pbc[bot]

@varshith257: You've been awarded a $180 bounty by tailcallhq! 👉 Complete your Algora onboarding to collect the bounty.

algora-pbc[bot] avatar May 15 '24 08:05 algora-pbc[bot]

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401 https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

tusharmath avatar May 16 '24 05:05 tusharmath

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401 https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

@tusharmath on it

mehulmathur16 avatar May 16 '24 05:05 mehulmathur16

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401 https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

Taking a look on it

varshith257 avatar May 16 '24 05:05 varshith257

@tusharmath Got the solution for it. Can you provide suggestion on how to test the behaviour of release workflow with changes?

Is release workflow run when packages updates?

It seems the errors occured in release workflow aren't related with this issue. Fixing it

varshith257 avatar May 16 '24 07:05 varshith257

@varshith257 @mehulmathur16 The builds are failing on the main, which is not allowing us to make any releases. Can you please check this out URGENTLY?

https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725401 https://github.com/tailcallhq/tailcall/actions/runs/9092466656/job/24989725711

@tusharmath Can re-run the workflows in above mentioned links? I think it's reverted pr got merged but I suscept feature flag doesn't causing of release build fails. But let's check-in

varshith257 avatar May 16 '24 13:05 varshith257

🎉🎈 @mehulmathur16 has been awarded $120! 🎈🎊

algora-pbc[bot] avatar May 20 '24 16:05 algora-pbc[bot]

💡 @ssddOnTop submitted a pull request that claims the bounty. You can visit your bounty board to reward.

algora-pbc[bot] avatar May 27 '24 12:05 algora-pbc[bot]

🎉🎈 @ssddOnTop has been awarded $180! 🎈🎊

algora-pbc[bot] avatar May 29 '24 07:05 algora-pbc[bot]