quick-xml icon indicating copy to clipboard operation
quick-xml copied to clipboard

Yet another approach to disable trim

Open ggodlewski opened this issue 5 months ago • 2 comments

I implemented disabling trim by modifying Text struct. See: https://github.com/tafia/quick-xml/issues/285#issuecomment-2863592598

I need this for parsing .odt files. Can anybody give me some feedback? This issue is 4 years old and I'm willing to fix it if possible.

ggodlewski avatar May 29 '25 15:05 ggodlewski

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.35802% with 14 lines in your changes missing coverage. Please review.

Project coverage is 60.42%. Comparing base (254fbd2) to head (0adae15). Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
src/de/mod.rs 91.02% 14 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   60.74%   60.42%   -0.32%     
==========================================
  Files          41       42       +1     
  Lines       16044    16488     +444     
==========================================
+ Hits         9746     9963     +217     
- Misses       6298     6525     +227     
Flag Coverage Δ
unittests 60.42% <91.35%> (-0.32%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 29 '25 18:05 codecov-commenter

@Mingun that solves my issue. Thanks for the changes, I'm just not familiar with this project.

ggodlewski avatar Jun 07 '25 17:06 ggodlewski