pljava icon indicating copy to clipboard operation
pljava copied to clipboard

support for PostgreSQL 18 : here is a small patch

Open achix opened this issue 6 months ago • 1 comments

postgres@smadevnu:~/src/pljava % git diff diff --git a/pljava-so/src/main/c/VarlenaWrapper.c b/pljava-so/src/main/c/VarlenaWrapper.c index cb1d9e7a..d36c4da4 100644 --- a/pljava-so/src/main/c/VarlenaWrapper.c +++ b/pljava-so/src/main/c/VarlenaWrapper.c @@ -36,6 +36,10 @@ #define GetOldestSnapshot() NULL #endif

+#if PG_VERSION_NUM >= 180000 +#define GetOldestSnapshot() NULL +#endif + #define _VL_TYPE struct varlena *

#if PG_VERSION_NUM < 140000 postgres@smadevnu:~/src/pljava %

achix avatar May 13 '25 14:05 achix

Hmm. Culprit seems to be postgres/postgres@4d82750. I think probably get_toast_snapshot() for the win.

jcflack avatar May 25 '25 13:05 jcflack

Are you planning to do a release supporting PG18? That would be one PG18 TODO list item less on my list.

df7cb avatar Jun 02 '25 15:06 df7cb

I believe the most recent merged pull request #529 should take care of PG18. A test build from the REL1_6_STABLE branch ought to work now.

I always have a bit of internal debate about how early to cut the official release. Maybe when there's an 18 release candidate?

jcflack avatar Jun 02 '25 15:06 jcflack

RC would be very late. How about now? 18 Beta1 is out, that would also allow people to beta-test pljava on 18. Yes, sometimes features get reverted that might break extensions again, or there might be more changes, but that's not the norm.

df7cb avatar Jun 02 '25 15:06 df7cb

Believed resolved in 1.6.10. Sorry for the delay. (On the bright side, also allowed confirming the release works with Java 25.)

jcflack avatar Sep 29 '25 16:09 jcflack