tabler icon indicating copy to clipboard operation
tabler copied to clipboard

[BUG] Important alert unreadable

Open kevinpapst opened this issue 9 months ago • 7 comments

Describe the bug

This is a follow-up of #2141 - I create this bug post, as I guess my comment goes unnoticed otherwise.

The alerts were recently refactored and some parts are worse now:

  • The "important" version is not popping out any more, I use them for toast messages and they will not work like that.
  • Even more important: they are hard to read now. Regular mode is already hard to read, but dark mode is literally impossible: I cannot read the new danger+warning at all. And I am only wearing "normal" glasses (like every IT person who looked at screens for 30+ years). The red and orange font is so blurry, that it is impossible to identify the text.

I would vote to revert the changes for the important alerts completely, they were perfect before (for my use-cases):

  • If you prefer the new version, can we please get the old ones back as additional classes?
  • Such brutal changes are BC breaks in my opinion and should be avoided

How to reproduce

Refactored in https://github.com/tabler/tabler/pull/2141

Preview see https://preview.tabler.io/alerts.html?theme=dark

Screenshots

I am using this "Accessibility insights for Web" plugin and it also reports contrast issues on these elements (the grey text and the red text especially): Bildschirmfoto 2025-02-28 um 09 23 55 Bildschirmfoto 2025-02-28 um 09 24 24

Before Bildschirmfoto 2025-02-28 um 00 36 59

Bildschirmfoto 2025-02-28 um 00 39 27

After Bildschirmfoto 2025-02-28 um 00 37 11

Bildschirmfoto 2025-02-28 um 00 39 16

JSFiddle

No response

kevinpapst avatar Mar 03 '25 13:03 kevinpapst

I also agree. The new v1.1.1 alerts are terrible. You can't read them and they are unclear if they are a success, error or something else.

Danny159 avatar Mar 04 '25 21:03 Danny159

okay, I'll try to improve it in next release

codecalm avatar Mar 04 '25 21:03 codecalm

Thanks @codecalm - the new update is great otherwise! Great code 🥇

Danny159 avatar Mar 04 '25 21:03 Danny159

+1 for the contrast of the previous alert design. The new ones are way too subtle. Happy to have new options but keep some of the previous style. Thanks for the hard work! 👍

AnnoyedPlatypus avatar Mar 07 '25 21:03 AnnoyedPlatypus

Works in progress: https://tabler-git-dev-alerts-upgrade-tabler-io.vercel.app/alerts.html?theme=light

Share your feedback in https://github.com/tabler/tabler/pull/2239

kevinpapst avatar Mar 24 '25 19:03 kevinpapst

That looks much better. Love it.

Danny159 avatar Mar 25 '25 09:03 Danny159

fixed 🙂

codecalm avatar May 11 '25 11:05 codecalm