Florian Meißner

Results 18 comments of Florian Meißner

Btw: what is the double purpose of cleaning in [main()](https://github.com/alexheretic/ab-av1/blob/2ad10eec75dea4719c025ed7949a7dfae90e7790/src/main.rs#L53) and [sample_encode::run](https://github.com/alexheretic/ab-av1/blob/2ad10eec75dea4719c025ed7949a7dfae90e7790/src/command/sample_encode.rs#L272)

> We could of course expand the abbreviation after the completion has been picked _if_ the completion entry was an abbreviation (we should always be careful if people add abbrs...

Thanks for your input! > I would prefer if you reconsidered the design decision of stopping/restarting play. A sudden stop in audio can be very noticable. I agree, my gut...

```bash > ~/.cache/cargo_target/debug/av1an --probing-rate 5 error: invalid value '5' for '--probing-rate ': 5 is not in 1..=4 For more information, try '--help'. ``` Should be mergable now

I think your answer points out very accurately the decisions to be done about design direction - how much the target of the app is to be used by users...

Thanks for the feedback, I see your point! I will adapt my changes as soon as I find time.

I conducted an experiment and found out the following: `--exclude`ing absolute paths works only if the folder that is watched is also supplied as an absolute path. (It makes sense...