lz4mt icon indicating copy to clipboard operation
lz4mt copied to clipboard

Advanced options -s and -m not working?

Open ghost opened this issue 12 years ago • 3 comments

I guess I've used this options in a previous version of lz4mt, but with the current one they do not work. There is no parsing of the options in the code.

Were they removed (are they coming back?) or am I missing something really basic? Would be great to have them as also a "max thread number" option :)

ghost avatar Sep 04 '13 17:09 ghost

Hi samuel.

Yes, you are right. -s and -m are removed. There is a command-line option incompatibility since a00ed228b4. I'm sorry for inconvenience.

And your "max thread number" option sounds good :+1: Since I've decided lz4mt should be maximum compatible with lz4c. New lz4mts exclusive option will look like following:

option means
--lz4mt-thread 0 Compatible -m. Use all available threads.
--lz4mt-thread 1 Compatible -s. Use single thread.
--lz4mt-thread N Use N threads.(Future plan. Depends on thread pool implementation)

I'll add new issue to implement this new option later.

t-mat avatar Sep 05 '13 15:09 t-mat

Ah that's great! I'm glad that the options will be back :+1: Do you have an estimate for when?

ghost avatar Sep 09 '13 11:09 ghost

I've just push branch fix-issue-19. I'll merge this branch in a few days.

t-mat avatar Sep 09 '13 17:09 t-mat