Takayuki Matsuoka

Results 132 comments of Takayuki Matsuoka
trafficstars

@Cyan4973 I added this issue (license update) to `v1.9.5`. But please feel free to change it. @autoantwort, thanks for the reply. AFAIK, `v1.9.5` - the next release will ship in...

> Ok iiuc the lib is BSD-2-Clause and since the vcpkg port only builds the lib and no test and cli tools the current > expression could already changed to...

If you refer [`kjdev/php-ext-lz4`](https://github.com/kjdev/php-ext-lz4), it doesn't support the [LZ4 frame format](https://github.com/lz4/lz4/blob/dev/doc/lz4_Frame_format.md). I mean `kjdev/php-ext-lz4` uses [low-level / raw LZ4 functions](https://github.com/kjdev/php-ext-lz4/blob/554722c1068a7db15f87a49ab14abae33d4db83d/lz4.c#L176-L237) which don't provide interoperability between languages/systems/CPUs. - See also: https://github.com/kjdev/php-ext-lz4/blob/554722c1068a7db15f87a49ab14abae33d4db83d/lz4.c#L39-L41...

LGTM! Sorry for the delay. @Cyan4973 Since I'm moving to new house, my reply may be delayed. 🙏

As for compiler issue, older version of simpler C compiler such as tcc may help us. But I don't check it yet.

Hi @doraorak, Thanks for the report. This is a good point. Because C++ standard [n4950](https://open-std.org/jtc1/sc22/wg21/docs/papers/2023/n4950.pdf) has the following words: > 16.4.3.2 Headers [using.headers] > A translation unit shall include a...

Hi, @Jay-Lokhande Since it seems Yann is busy for now, I'm asking basic question. Do you observe actual benefit from your inline assembly implementation? I mean that every version of...

> What do you think adding RISC-V support in xxHash will be beneficial would you like to give me any suggestions over it should I go ahead with the changes...

> Does that plan sound good? Yes, it sounds good as a first step. > Are there any additional input sizes or flags you’d recommend including in the benchmark? Having...

Before further discussion, all tests including sanity check must be passed. Since failure of sanity check means broken calculation, please debug your patch.