phpstan-wordpress icon indicating copy to clipboard operation
phpstan-wordpress copied to clipboard

Introduce conditionalTags

Open IanDelMar opened this issue 1 year ago • 5 comments

Allows rules to be disabled. Rules are enabled by default.

IanDelMar avatar Nov 17 '24 13:11 IanDelMar

Thank you for this PR.

Do we work on this package because we want users partially use it?

szepeviktor avatar Nov 17 '24 14:11 szepeviktor

I was considering more 'controversial' rules that we might want to add (e.g., your suggestion in #197 or possibly enforcing DocBlocks for hooks). If we apply this approach to some rules, why not apply it to all rules?

IanDelMar avatar Nov 17 '24 14:11 IanDelMar

more 'controversial' rules

Using static analysis for "'code'" (scripts) written for WordPress is 100% controversial.

szepeviktor avatar Nov 17 '24 14:11 szepeviktor

What we three see okay for this package that must be used by all.

szepeviktor avatar Nov 17 '24 14:11 szepeviktor

Using static analysis for "'code'" (scripts) written for WordPress is 100% controversial.

@IanDelMar Have you seen what others come up with before this package? Tragedy!

szepeviktor avatar Nov 17 '24 14:11 szepeviktor