Sidney Glinton comments

Results 26 comments of


                                            Sidney Glinton

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

@rareddy it is. That's what Debarati is asking for that to be exposed to the client lib for testing.

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

> I think we need confirmation from @dbasunag and others we're not going to remove the MR py client user method testing. Yes from my talk from @dbasunag we are...

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

We might not need to expose the client, We might be able to just use/do this: ``` mr = ModelRegistry(...) raw_client_fnc = mr._api.get_client async with raw_client_fnc() as raw_client: raw_client.create_registered_model(...) #

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

I believe we can close this out :) @tarilabs @dbasunag

[Ongoing] Capture gaps in MR codebase to make more pragmatic

To start, suggestion to eventually modularize the client code more and split out larger files. https://github.com/kubeflow/model-registry/pull/1111#issuecomment-2883991681

[Ongoing] Capture gaps in MR codebase to make more pragmatic

@tarilabs yes we can do that. We can address in a cleanup for it at a later date?

[Ongoing] Capture gaps in MR codebase to make more pragmatic

I believe we should move `as_mlops_engineer_i_` itests the Python client tests and move them to a dedicated file to de-clutter the tests. re: https://github.com/kubeflow/model-registry/blob/a56dc202495c6a04d3ab90243befecf072cf29f3/clients/python/tests/test_client.py#L1181 and re: https://github.com/kubeflow/model-registry/blob/a56dc202495c6a04d3ab90243befecf072cf29f3/clients/python/tests/regression_test.py#L140 please note they...

Sidney Glinton

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

Requesting model registry python client to expose create() calls for register_model, model_version, model_artifacts etc.

[Ongoing] Capture gaps in MR codebase to make more pragmatic

[Ongoing] Capture gaps in MR codebase to make more pragmatic

[Ongoing] Capture gaps in MR codebase to make more pragmatic

fix pd compatibility

fix pd compatibility

fix pd compatibility