website icon indicating copy to clipboard operation
website copied to clipboard

Scroll to top after clicking on an episode

Open simeydk opened this issue 7 years ago • 14 comments
trafficstars

This is a nice-to-have proposed improvement.

Now that the list of episodes is getting longer, the experience when clicking on an older episode is not great. Most users would do this with the intent of reading the shownotes for that episode, presumably from the start. However, when clicking on an older episode far down the list, the scroll position remains far down and the user has to scroll all the way back up by hand (see GIF below) #firstworldproblems.

Proposed solutions:

  • Add a "scroll to top" button; and/or
  • automatically scroll to top when a user clicks on an episode, and/or
  • separate scrolling for episode list and shownotes

syntax scroll to top

simeydk avatar Aug 27 '18 07:08 simeydk

I would be keen to have a stab at implementing something for this, if you're keen to make a change here. If so, which solution would you prefer?

(Naturally, you are also most welcome to close this issue if you're not phased by this)

simeydk avatar Aug 27 '18 07:08 simeydk

@simeydk yeah wouldn't be a bad improvement, I was thinking maybe having a fixed height for the list of episodes and info. This way when you click on a episode the info list would scroll independent from the episode list.

drubiodev avatar Aug 31 '18 17:08 drubiodev

would be great :)

wesbos avatar Oct 02 '18 13:10 wesbos

If nobody else is looking at this, I'd love to give this a shot :)

ClayBenson94 avatar Oct 02 '18 13:10 ClayBenson94

If nobody else is looking at this, I'd love to give this a shot :)

I offered to give it a stab before, but am not getting round to it, so happy to "give it up" (if I ever had it). The maintainers seem keen so I would think it's fine.

simeydk avatar Oct 02 '18 14:10 simeydk

I just saw @legarland submitted a PR for this, #113 (a month before I opened the issue!)

simeydk avatar Oct 02 '18 14:10 simeydk

I just noticed this as well, would be great!

Edit: Syntax is awesome! :heart:

JohanG2012 avatar Oct 07 '18 17:10 JohanG2012

This what you where thinking?

2e7d6b84cd90d42bf0e4c74ea3dc395b

ghost avatar Oct 08 '18 20:10 ghost

@jameygleason would you be able to scroll it to the top of <main />. That's where the player starts and I think that would be a better experience for users.

sergical avatar Oct 08 '18 22:10 sergical

Check out my PR #113 to see if the experience fits this issue. I noticed this a while back and decided to add the smooth scrool functionality.

legarland avatar Oct 08 '18 22:10 legarland

@jameygleason would you be able to scroll it to the top of <main />. That's where the player starts and I think that would be a better experience for users.

Yeah totally. Give me an hour or so.

ghost avatar Oct 08 '18 22:10 ghost

Check out my PR #113 to see if the experience fits this issue. I noticed this a while back and decided to add the smooth scrool functionality.

@legarland looks good. I'm interested in knowing more about the polyfill.

ghost avatar Oct 08 '18 23:10 ghost

Alright, I think I got it. Share your thoughts.

#184

cfac0ff45c8c9d08c640869050a6d896

@416serg @wesbos

ghost avatar Oct 09 '18 16:10 ghost

No longer an issue.

csellis avatar Oct 04 '19 01:10 csellis