sympy.github.com icon indicating copy to clipboard operation
sympy.github.com copied to clipboard

Finnish translation added

Open jremes-foss opened this issue 10 years ago • 22 comments

Finnish translation added to sympy.github.com site. All strings translated.

If there is anything else regarding this, please let me know.

Thank you.

jremes-foss avatar Nov 04 '15 14:11 jremes-foss

@pv, would you mind quickly reviewing the Finnish translation (to make sure it's high enough quality so that we can merge it)? It's just the fi.po file: https://github.com/Newman101/sympy.github.com/blob/3046d8bbc689cea12cfbfb25ba81357d4f08960a/i18n/fi.po, everything else is auto generated. That would be a big help, as I don't speak Finnish, so I can't review it myself.

certik avatar Nov 04 '15 15:11 certik

Hi. As per request, I changed word "patch" to "korjaustiedosto" which is more accurate translation.

jremes-foss avatar Nov 04 '15 16:11 jremes-foss

Thanks @jksuom. Is there anything else?

certik avatar Nov 04 '15 16:11 certik

Another possible translation for 'patch' could be 'muutostiedosto' (muutos = change). That would cover about everything, additions, deletions, and fixes. (Though patches often are thought of as fixes (korjaus = fix).)

jksuom avatar Nov 04 '15 20:11 jksuom

Most suggestions are now covered. Only issue is fi/features.html, line 146. This entry is not found in the .po file.

jremes-foss avatar Nov 05 '15 11:11 jremes-foss

Overall LGTM. It's been 10+ years since I last touched .po files :)

pv avatar Nov 05 '15 16:11 pv

Most of these suggestions are now done, I just need to add the missing pieces to .po - file.

jremes-foss avatar Nov 05 '15 17:11 jremes-foss

I think that was about all I could suggest. It looks good to me now.

jksuom avatar Nov 05 '15 20:11 jksuom

@pv and @jksuom thanks a lot for reviewing this!

@Newman101 let me know when this is ready to be merged.

certik avatar Nov 05 '15 20:11 certik

Ok, last issue has been fixed - I added the missing string to .po file. I think this can be merged now.

jremes-foss avatar Nov 06 '15 16:11 jremes-foss

Thanks! Don't you have to regenerate the files when the po file changes?

certik avatar Nov 10 '15 15:11 certik

I think I did, but apparently I didn't. Thank you for notifying - I'll re-generate the pages and commit the changes.

jremes-foss avatar Nov 10 '15 19:11 jremes-foss

Ok, looks like the last change in .po file was not actually reflected in the web pages. This is why the pages were not committed because there were no changes to commit.

jremes-foss avatar Nov 10 '15 20:11 jremes-foss

I'll need to investigate why this happens.

jremes-foss avatar Nov 10 '15 20:11 jremes-foss

Looks like the generate script discards all the manually added entries. So I need to investigate whether msgmerge would actually have any effect.

http://stackoverflow.com/questions/7680021/how-to-add-a-new-string-to-a-po-file-w-a-po-editor

jremes-foss avatar Nov 10 '15 20:11 jremes-foss

I tried merging it with msgmerge but that did not help either. Attempted to update the string from the sympy.org.pot file and update the po but that was a failure as well. Any other good ideas? Looks like everything I try to do ends up to dead end.

jremes-foss avatar Nov 10 '15 20:11 jremes-foss

There is something dodgy here. "Permutation Groups" refers to line features.html:124, but in reality it is in features.html:146. Also, the colon is in the web page but not in the translation file.

jremes-foss avatar Nov 10 '15 21:11 jremes-foss

The question follows: Why "Permutation Groups" got translated but "Polyhedral, Rubik, Symmetric, ..." didn't? After all, they are both supposed to be on the same line.

jremes-foss avatar Nov 10 '15 21:11 jremes-foss

This might be an issue on other localizations as well.

jremes-foss avatar Nov 10 '15 21:11 jremes-foss

Sorry for the problems. Did you run ./extract_i18n_text to create the initial template? That one should be correct and correspond to the current sources. Then you just merge it with your current translation.

certik avatar Nov 10 '15 22:11 certik

I am fairly certain I did, but I can re-attempt that tomorrow morning.

jremes-foss avatar Nov 10 '15 22:11 jremes-foss

Still investigating the issue with that last problematic string. Is any of the languages fully translated and functional?

jremes-foss avatar Dec 14 '15 15:12 jremes-foss