Use ComponentAttributes everywhere in project

[seb-jean]

Hi,

It would be great to be able to use ComponentAttributes everywhere in project but ComponentAttributes is marked as @internal

For instance:

<?php

namespace App\Twig;

use Symfony\UX\TwigComponent\ComponentAttributes;
use Twig\Extension\AbstractExtension;
use Twig\TwigFunction;

class AriaExtension extends AbstractExtension
{
    public function getFunctions(): array
    {
        return [
            new TwigFunction('aria_dialog', [$this, 'ariaDialog']),
        ];
    }

    public function ariaDialog()
    {
        $attributes = [
            'data-controller' => 'dialog',
            'role' => 'dialog',
            'aria-modal' => 'true',
        ];

        return new ComponentAttributes($attributes);
    }
}

[kbond]

If there is an external use-case for something marked as internal, I'm fine with removing @internal.

[seb-jean]

An example use case is generating HTML attributes like the Twig extension, above. But it is not a component.

[kbond]

Yep, looks legit to me!

[seb-jean]

Maybe we could rename ComponentAttributes to HtmlAttributes?

[kbond]

I'd be fine with this as well. @weaverryan, any objections?

[seb-jean]

Hi @weaverryan, Do you have any objections?

[wouterj]

It's often better to start a PR if the change is scoped like this one. Easier to judge the impact, and PRs often get more attention than issues :)

[weaverryan]

Yes, PR please! No objections from me, including the name change.