symfony-docs icon indicating copy to clipboard operation
symfony-docs copied to clipboard

[AssetMapper] Adding updater to comparison table

Open ThomasLandauer opened this issue 1 year ago • 3 comments

Page: https://symfony.com/doc/6.4/frontend.html#using-php-twig

Reason: It's a cool feature :-)

ThomasLandauer avatar Feb 15 '24 19:02 ThomasLandauer

The new entry is a bit confusing. I'd change it for Can update 3rd party packages

If that's the true mining of what we're adding here ... I'm not sure we should say yes for Webpack Encore because it doesn't include any command/feature to update packages. AssetMapper has importmap:update but Encore has nothing like it (you can update packages with npm, yarn, etc. ... but that's not Encore).

javiereguiluz avatar Feb 16 '24 12:02 javiereguiluz

I updated the wording. Maybe add a link to npm-check? 2 arguments for this change:

  • When switching from Encore to AssetMapper, it's important to know that there is still an updater.
  • People not familiar with JS bundlers might not know that NPM has one.

ThomasLandauer avatar Feb 16 '24 13:02 ThomasLandauer

AssetMapper has importmap:update but Encore has nothing like it (you can update packages with npm, yarn, etc. ... but that's not Encore).

Hmm.. to be honest Encore has nothing like it because... if you have Encore you have yarn or npm or pnpm or (...) for that :) So Encore would have no reason to implement such command.

I'm thinking all the lines have really different "importances" in term of comparaison, and we may want to split the table in distinct aspects (compatibility, dx, standards, ..)

smnandre avatar Feb 16 '24 14:02 smnandre

Thanks Thomas! While merging I changed the value of this row for Encore to say no instead of yes (see https://github.com/symfony/symfony-docs/commit/0a6719096d20359d044d1fd964d0b319637de2c7). Encore doesn't have any feature to update packages. You can do it via npm, but that's not encore. Thanks!

javiereguiluz avatar Mar 25 '24 15:03 javiereguiluz