polyfill issues

mb_strlen returns 0 instead of 1 for the char chr(254)

7

Hi, With the polyfill, `var_dump(mb_strlen(chr(254)))` return `0`. With the php8.0-mbstring extension, var_dump(mb_strlen(chr(254))) return `1`; `versions : * v1.26.0` Thanks, Alex

alexchuin

help wanted

Mb trim functions

2

Fixes #458 Implementaion of `mb_trim`, `mb_ltrim` and `mb_rtrim` Tests from the php-src repository

Fan2Shrek

Add Mbstring::assertEncoding()

2

The same pattern of encoding checks is required in another method, so you can separate encoding assertions and avoid copy-pasting. refs https://github.com/symfony/polyfill/pull/466/files#r1545573878 Cc: @Ayesh

zonuexe

Function signature checking should be improved

1

[These errors](https://github.com/symfony/polyfill/actions/runs/8494636417/job/23270054252?pr=471#step:6:1350) below looks strange: ``` 40) Warning Incompatible signature for PHP >= 8: - mb_ucfirst(string $string, ?string $encoding = null): string + mb_ucfirst(string $string, ?string $encoding = null): string...

zonuexe

Inconsistent function calls in test cases

It is inconsistent whether to call built-in functions or polyfill methods in test cases. refs https://github.com/symfony/polyfill/pull/471/files#r1545524686 I'm also interested in improving these tests, but it looks like I won't be...

zonuexe

[PHP 8.4][Intl] Add `grapheme_str_split`

8

Adds a polyfill for the `grapheme_str_split` function added in PHP 8.4. Requires PHP 7.3, because the polyfill is based on `\X` Regex, and it only works properly on PCRE2, which...

Ayesh

enhancement

[PHP 8.4] Add `CURL_HTTP_VERSION_3(ONLY)` constants

5

If the underlying Curl build supports it, setting the HTTP version should be theoretically possible. The availability of the constants do not guarantee the feature support, so declaring them in...

Ayesh