polyfill icon indicating copy to clipboard operation
polyfill copied to clipboard

Intl Transliterator - polyfill

Open voku opened this issue 6 years ago • 4 comments

TODO:

  • [ ] add more tests - https://github.com/voku/polyfill/blob/intl_transliterator/tests/Intl/Transliterator/TransliteratorTest.php
  • [x] not working as expected for PHP <= 5.5
  • [ ] some tests did not work on travis-ci (old ICU version)

QUESTIONS:

  • [ ] do we need support for "Transliterator->direction"?

reference: https://github.com/voku/portable-ascii/issues/32


This change is Reviewable

voku avatar Oct 08 '19 22:10 voku

@nicolas-grekas Hi, here is my first quick try to move the ASCII stuff into a "Transliterator"-polyfill. Maybe you can take a look at this if you have time, thanks.

voku avatar Oct 08 '19 22:10 voku

@voku well, debugging why some garbage is returned when running on such old version ?

stof avatar Oct 18 '19 10:10 stof

@stof Garbage was return because old PHP versions do not use "UTF-8" encoding by default.

voku avatar Oct 19 '19 01:10 voku

Do we want to support the INTL_ICU_VERSION constant?

chx avatar Jun 14 '20 22:06 chx

Sorry we didn't catch up on this topic. The amount of work is too high I suppose. Please let me close. Thanks for the PR!

nicolas-grekas avatar Apr 12 '24 09:04 nicolas-grekas