Suggestion: Rename PANTHER_ERROR_SCREENSHOT_DIR to PANTHER_SCREENSHOT_DIR ...

[ThomasLandauer]

... and use it for "normal" screenshots too.

When taking a screenshot with $client->takeScreenshot('screenshot.png'); the file is always created in public, right? So I'm suggesting to make this configurable, and (re)use the PANTHER_ERROR_SCREENSHOT_DIR environment variable for it.

[arderyp]

Here I am unable to get PANTHER_ERROR_SCREENSHOT_DIR to work at all. The 1.0.0 release notes state "Automatically take a screenshot when a test fail and if the PANTHER_ERROR_SCREENSHOT_DIR environment variable is set"

My phpunit.xml contains:

  <!-- ###+ symfony/panther ### -->
  <extensions>
    <extension class="Symfony\Component\Panther\ServerExtension" />
  </extensions>
  <!-- ###- symfony/panther ### -->

  <listeners>
    <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener"/>
  </listeners>

  <php>
    ...
    
    <!-- ###+ symfony/panther ### -->
    <env name="PANTHER_ERROR_SCREENSHOT_DIR" value="/home/USER/Downloads"/>
    <!-- ###- symfony/panther ### -->
    
    ...
  </php>

And yet, on failed tests, no screenshot images are written anywhere, as far as I can tell. I've even tried adding $this->takeScreenshotIfTestFailed(); to setUp() on my base class. No effect.