Panther Crawler needs rework

[acantepie]

Hi,

A list of non-exhaustive things.

• Some method are not typed (ex missing @return WebDriverElement[] on findElements method, filter() should take a string... etc)
• selectFromXpathand filterXPathdoes the same thing.
• I don't understand the visibility of methods : ̀getElement' is public while getElementOrThrow is private.
• It's hard to understand why some methods return a Crawler (that implements WebDriverElement) and why some others methods return a WebDriverElement ..
• You can use WebDriverBy object with getElements method while you can only use an xpath or cssSelector with filter / filterXPath methods..
• selectXXX methods must be commented and xpath are too restricive for real usage.
• All methods from WebTestAssertionsTrait or Client take string locator in contrary of Panther Crawler. This string is used to determine the WebDriverBy used with poor logic.

[ThomasLandauer]

• Rename the entire class to PantherCrawler to avoid confusion with Symfony's DomCrawler. Internally, you're using this alias anyway :-) use Symfony\Component\Panther\DomCrawler\Crawler as PantherCrawler;