menu-bundle icon indicating copy to clipboard operation
menu-bundle copied to clipboard

Allow knp-menu 3.x

Open EmmanuelVella opened this issue 5 years ago • 0 comments

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
License MIT

Hi !

Since version 3.75.0, sonata-project/admin-bundle required knplabs/menu-bundle ^3.0. This is a PR to upgrade this bundle to the same version. As methods signatures changed, this is a BC break update. It works on my personnal project.

However I currently have an issue because in some methods we must now return a non-null ItemInterface item. Any ideas what could be a better fix than what I did ?

EmmanuelVella avatar Sep 23 '20 15:09 EmmanuelVella