symengine.rb icon indicating copy to clipboard operation
symengine.rb copied to clipboard

Decide which ruby versions to support

Open isuruf opened this issue 9 years ago • 5 comments

In travis, we test,

  • 1.9.3
  • 2.0
  • 2.1
  • 2.2
  • 2.3.0

We initially included these because these were the ones supported in NMatrix I think.

Since official support for 1.9.3 is stopped including security patches, I'm okay with dropping 1.9.3. What do you think?

@zverok, @certik, @abinashmeher999, @rajithv, @mohawkjohn, @v0dro

isuruf avatar Jun 01 '16 07:06 isuruf

I'd boldly say that 2.0 should go away too. It is already deprecated, and 2.1 have significantly superior features (keyword arguments and refinements), and as SymEngine is more than any other SciRuby project needs clean modern API, ...

zverok avatar Jun 01 '16 07:06 zverok

I'd still say go with ruby 2+ for now and then drop support by the end of the year.

v0dro avatar Jun 01 '16 07:06 v0dro

Since 1.9.3 is the only one that is making us take extra effort to write compatible code, that should be the one to go first. One of the tests for 1.9.3 fails on OS X too.

For 2.0 we haven't had any problems yet, I think. Let us keep the tests for 2.0 for now and when we come across another issue where something is not supported in 2.0 we can drop it then.

On Wed, Jun 1, 2016, 1:25 PM Sameer Deshmukh [email protected] wrote:

I'd still say go with ruby 2+ for now and then drop support by the end of the year.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/symengine/symengine.rb/issues/48#issuecomment-222919724, or mute the thread https://github.com/notifications/unsubscribe/AGmQ6zgn8zcLjQxHpJ0YrE5v6Bium4iUks5qHTsDgaJpZM4IrQ2r .

abinashmeher999 avatar Jun 01 '16 08:06 abinashmeher999

Let's drop 1.9.3. since it doesn't receive security patches. We can probably drop 2.0 as well, but we can also be conservative and drop it a bit later.

Sent from my mobile phone. On Jun 1, 2016 9:32 AM, "Isuru Fernando" [email protected] wrote:

In travis, we test,

  • 1.9.3
  • 2.0
  • 2.1
  • 2.2
  • 2.3.0 We initially included these because these were the ones supported in NMatrix I think.

Since official support for 1.9.3 is stopped including security patches, I'm okay with dropping 1.9.3. What do you think?

@zverok https://github.com/zverok, @certik https://github.com/certik, @abinashmeher999 https://github.com/abinashmeher999, @rajithv https://github.com/rajithv, @mohawkjohn https://github.com/mohawkjohn, @v0dro https://github.com/v0dro

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/symengine/symengine.rb/issues/48, or mute the thread https://github.com/notifications/unsubscribe/AABQWCc4aGKtICbaC_nyx2Br5Zh0n2BAks5qHTV4gaJpZM4IrQ2r .

certik avatar Jun 01 '16 11:06 certik

Seems 2.0 also doesn't receive security patches. We should drop 2.0 as well.

isuruf avatar Oct 08 '16 10:10 isuruf