spacemacs icon indicating copy to clipboard operation
spacemacs copied to clipboard

Missing key binding

Open ejez opened this issue 5 years ago • 4 comments

Description :octocat:

Missing key binding

Reproduction guide :beetle:

  • Start Emacs
  • Press SPC s r r

Observed behaviour: :eyes: :broken_heart: SPC s r r is undefined

Expected behaviour: :heart: :smile: According to the doc, the above key sequence should be bound to "search current file with ripgrep".

System Info :computer:

  • OS: gnu/linux
  • Emacs: 26.3
  • Spacemacs: 0.300.0
  • Spacemacs branch: develop (rev. 015303a70)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
(emacs-lisp helm multiple-cursors treemacs)
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD LCMS2

ejez avatar May 19 '20 01:05 ejez

I think no code exist to search current file using rg, and I don't think we should write such code when there are so many other options.

IMHO we should simply remove the two lines from the documentation, i.e., apply this patch:

diff --git a/doc/DOCUMENTATION.org b/doc/DOCUMENTATION.org
index 7f1e6e4..659ea7d 100644
--- a/doc/DOCUMENTATION.org
+++ b/doc/DOCUMENTATION.org
@@ -2757,8 +2757,6 @@ bindings (~SPC e n~ and ~SPC e p~) as well as the error transient state (~SPC e
 | ~SPC s a A~ | =ag= with default input                             |
 | ~SPC s g g~ | =grep=                                              |
 | ~SPC s g G~ | =grep= with default input                           |
-| ~SPC s r r~ | =rg=                                                |
-| ~SPC s r R~ | =rg= with default input                             |
 
 **** Searching in all open buffers visiting files

emacs18 avatar Jun 08 '20 17:06 emacs18

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

github-actions[bot] avatar Jun 08 '21 17:06 github-actions[bot]

I've a unfinished PR that adds the functionality to ripgrep.

Stay tuned. It was started in late 2019 and probably it will finish this year. (it's already working)

lebensterben avatar Aug 24 '21 01:08 lebensterben

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

github-actions[bot] avatar Sep 10 '22 20:09 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

github-actions[bot] avatar Mar 29 '24 23:03 github-actions[bot]