design-system
design-system copied to clipboard
[bug]: center target group text
🐞 Describe the bug
Target group text is off centered.
🛠️ To Reproduce
Steps to reproduce the behavior:
- Go to the header documentation page
- Make sure the "Target group" option is enabled
- Check the header example on desktop scrolled all the way to the top
- See that the selected target group text is not vertically centered compared to its black container
✨ Expected behavior
The text should be centered.
📷 Screenshots
EDGE
Windows
Mac
CHROME
Windows
Mac
FIREFOX
Windows
Mac
// TODO
- Get team input in Pattern Discussion
- Proposal: Find out largest user base and adjust accordingly
- ➡️ Ask Post Portal team or Analytics department
@sandra-post @rouvenpost Can you have a look and come back to us with a proposal?
There are two issues:
- the text is off-centered because of the 3px/5px block padding (implemented as designed, will be checked by Rouven and Sandra)
- the links themselves are off-centered, because they have an inline display, the wrapping
<li>adds an unwanted padding
Resolution Padding was updated to 4px/4px top and bottom and should be updated on dev side as well.
Also, links cannot be disabled, adding button disabled styles adds unnecessary code.