design-system icon indicating copy to clipboard operation
design-system copied to clipboard

[bug]: center target group text

Open alizedebray opened this issue 2 months ago • 5 comments

🐞 Describe the bug

Target group text is off centered.

🛠️ To Reproduce

Steps to reproduce the behavior:

  1. Go to the header documentation page
  2. Make sure the "Target group" option is enabled
  3. Check the header example on desktop scrolled all the way to the top
  4. See that the selected target group text is not vertically centered compared to its black container

✨ Expected behavior

The text should be centered.

📷 Screenshots

EDGE

Windows Image

Mac Image

CHROME

Windows Image

Mac Image

FIREFOX

Windows Image

Mac Image

alizedebray avatar Oct 03 '25 08:10 alizedebray

// TODO

  • Get team input in Pattern Discussion
  • Proposal: Find out largest user base and adjust accordingly
    • ➡️ Ask Post Portal team or Analytics department

sandra-post avatar Oct 06 '25 10:10 sandra-post

@sandra-post @rouvenpost Can you have a look and come back to us with a proposal?

leagrdv avatar Oct 07 '25 11:10 leagrdv

There are two issues:

  1. the text is off-centered because of the 3px/5px block padding (implemented as designed, will be checked by Rouven and Sandra)
  2. the links themselves are off-centered, because they have an inline display, the wrapping <li> adds an unwanted padding Image

alizedebray avatar Oct 07 '25 11:10 alizedebray

Resolution Padding was updated to 4px/4px top and bottom and should be updated on dev side as well.

leagrdv avatar Oct 14 '25 11:10 leagrdv

Also, links cannot be disabled, adding button disabled styles adds unnecessary code.

gfellerph avatar Oct 27 '25 14:10 gfellerph