design-system
design-system copied to clipboard
chore(styles): remove unused placeholder + cleanup
π Description
I noticed the %btn-transparent-background was never used so I removed it and cleaned up the other placeholder files to remove unnecessary imports.
π Demo
If applicable, please add a screenshot or video to illustrate the changes.
π Checklist
- β My code follows the style guidelines of this project
- π οΈ I have performed a self-review of my own code
- π I have made corresponding changes to the documentation
- β οΈ My changes generate no new warnings or errors
- π§ͺ I have added tests that prove my fix is effective or that my feature works
- βοΈ New and existing unit tests pass locally with my changes
β οΈ No Changeset found
Latest commit: eff220a99d6d2e19102c5c5f2d4968a73a986a1a
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git βοΈ
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| design-system-documentation | β Ready (Inspect) | Visit Preview | π¬ Add feedback | May 5, 2025 1:50pm |
Related Previews
- https://preview-5428--swisspost-design-system-next.netlify.app
In general, I'm fine with the update, but...
We never documented this placeholder, which means it's interal code that should not be in use by any project. Therefore, removing it, because it's not used anymore, would not be a changeset worthy update, imo.
If I'm right, we would not need to add a changeset and we would also not need to document it in the migration guide as a breaking change.
If I'm wrong, it should be
majorinstead ofminor.Please double check with @gfellerph or @alizedebray
I donβt have a strong opinion because it's probably not used at all, but I would consider it a major change since something was removed. It will be grouped with other major changes in v10 anyway. Also, since it was never documented, it doesn't need to be mentioned in the migration guide.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code