gitlab-merge-request-resource icon indicating copy to clipboard operation
gitlab-merge-request-resource copied to clipboard

Published 20 hours ago • verified publisher icon swisscom

Different timezone causes checks to skip merge requests

Open edtan opened this issue 6 years ago • 0 comments

I'm on an older version of GitLab - v10.8.3 - and the commits API returns the committed_date using the committer's time zone. e.g. "2018-12-06T17:17:38.214-05:00". However, the latest version of GitLab looks like it's returning the timezone in UTC ("2018-12-06T16:08:35.000Z", src).

check currently checks the first 19 characters of committed_date, which works if all times are returned in UTC. However, this causes the check to miss particular merge requests when the commits are in different zones (with older versions of GitLab). I can't seem to find which release of GitLab changed the committed_date format, but I believe it's related to this issue.

edtan avatar Dec 09 '18 16:12 edtan