swift icon indicating copy to clipboard operation
swift copied to clipboard

[5.9] always use the argNames constructor for macro DeclNames

Open QuietMisdreavus opened this issue 2 years ago • 1 comments

Cherry-pick of https://github.com/apple/swift/pull/66497

  • Explanation: Macros with no parameters have an inconsistent DeclName based on whether they were loaded from source code or a built-module.
  • Scope: Affects symbol graphs (and Swift-DocC documentation) for these macros.
  • Issue: rdar://110179186
  • Risk: Low. The deserialization logic that was removed was identical to the one that was left in its place, with the exception of which DeclName constructor is being used.
  • Testing: A test has been added to ensure that a parameterless macro has the same name regardless of whether it's loaded from source code or a built module.
  • Reviewer: @DougGregor

QuietMisdreavus avatar Jun 09 '23 16:06 QuietMisdreavus

@swift-ci Please test

QuietMisdreavus avatar Jun 09 '23 16:06 QuietMisdreavus

@swift-ci Please test

QuietMisdreavus avatar Jun 12 '23 15:06 QuietMisdreavus

@swift-ci Please test

QuietMisdreavus avatar Jun 12 '23 20:06 QuietMisdreavus