async-http-client

async-http-client copied to clipboard

Option for `HTTPClientError.remoteConnectionClosed`s to be automatically retried

1

In all apps i've used AHC in, we experience relatively-infrequent but consistent `HTTPClientError.remoteConnectionClosed`s. Frequency-wise, my non-scientific approximation would be something like 1/50_000 requests (depends on a lot of factors of...

MahdiBM

and fix other `Sendable` related warnings on the way. Proposal: https://github.com/apple/swift-nio/pull/2228 Experiment to see real word usage of the proposal.

dnadoba

Logging contains newlines (because it uses ByteBuffer.debugDescription which IMHO it shouldn't)

11

AHC logs bytes of the HTTP connection (which is in itself questionable #689). But even if we think that's okay I don't think it should just log `ByteBuffer.debugDescription` which contains...

weissi

Add `HTTPClient.Configuration.browserLike`

7

We should add a ``` extension HTTPClient.Configuration { public static var browserLike: Self { ... } } ``` which should return an evolving configuration that's always as close as possible...

weissi

HTTPClient.shared (like URLSession.shared)?

10

``` private let sharedSingleton: HTTPClient = { let httpClient = HTTPClient(eventLoopGroupProvider: .singleton) Unmanaged.takeUnretained(httpClient) // don't ever deinit this guy }() extension HTTPClient { public var shared: HTTPClient { return sharedSingleton...

weissi

Privacy & security: Clarify what we log at which log level

5

IIRC the initial design that we don't log anything private like URL, headers or even bytes at all. That might be a little strict though. But it's very important to...

weissi

It would be appreciated and useful to have a mechanism within AHC to handle Digest Auth

1

# Issue Some HTTP requests require authentication. Basic auth is easy for the user to implement, but rarely used (I assume). More frequently, Digest authentication is required. Digest Auth is...

Diggory

Authenticate using certificate and passphrase like curl's `--cert` option

2

I'm working with Vapor on Linux on a API which connects to a URL and send it a XML, this URL needs certificate authentication (.pem, or p12) and passphrase. Using...

garanda21

HTTP2 go away at the protocol level lets the request hang

3

[We currently ignore the error code of the go away](https://github.com/swift-server/async-http-client/blob/817d9aa99fe4c71e7bea18a9a74bc7a5fc166692/Sources/AsyncHTTPClient/ConnectionPool/HTTP2/HTTP2IdleHandler.swift#L65). I think if it is a protocol error we will never receive any further HTTP2Frame on the connection or any...

dnadoba

HttpClient removes Content-Length and causes 411

2

When attempting to make GET calls with Django based server, I'm getting a 411 Length Required. Looking at the code in *RequestValidation.swift*, it is removing `Content-Length` from headers for `GET`...

sherwinzadeh