async-http-client icon indicating copy to clipboard operation
async-http-client copied to clipboard

Add NIOSSLCustomVerificationCallback for HTTPClient

Open L1MeN9Yu opened this issue 5 years ago • 3 comments

We're using pin the public key for ssl-pinning, but there is no way to use NIOSSLCustomVerificationCallback in the NIOSSLClientHandler .

L1MeN9Yu avatar Jul 20 '20 02:07 L1MeN9Yu

While supporting only the NIOSSLCustomVerificationCallback is easy, supporting that and the equivalent functionality in Network.framework with a single code path is substantially harder. We should consider whether adding this support necessarily forces the TLS configuration to choose NIOSSL.

Lukasa avatar Jul 20 '20 06:07 Lukasa

@Lukasa There is already a path for choosing NIOSSL while running with NIOTS so wouldn't be a hard to implement, I imagine.

adam-fowler avatar Aug 07 '20 14:08 adam-fowler

The biggest complexity is about mapping TLS configuration.

Lukasa avatar Aug 07 '20 14:08 Lukasa