swc icon indicating copy to clipboard operation
swc copied to clipboard

fix: undefined params if using by stauren/vite-plugin-deadfile

Open Leubeling opened this issue 1 year ago • 3 comments

Description:

I use this library indirectly through stauren/vite-plugin-deadfile. I noticed an exception which occurs with every build due to an undefined array.

BREAKING CHANGE:

Related issue (if exists):

error during build:
[vite-plugin-pwa:build] Cannot read properties of undefined (reading 'map')
file: /projectfolder/src/main.ts
    at ImportVisitor.visitTsFnParameters (/projectfolder/node_modules/@swc/core/Visitor.js:589:23)
    at ImportVisitor.visitTsPropertySignature (/projectfolder/node_modules/@swc/core/Visitor.js:511:25)
    at ImportVisitor.visitTsTypeElement (/projectfolder/node_modules/@swc/core/Visitor.js:489:29)
    at Array.map (<anonymous>)
    at ImportVisitor.visitTsTypeElements (/projectfolder/node_modules/@swc/core/Visitor.js:480:22)
    at ImportVisitor.visitTsInterfaceBody (/projectfolder/node_modules/@swc/core/Visitor.js:476:23)
    at ImportVisitor.visitTsInterfaceDeclaration (/projectfolder/node_modules/@swc/core/Visitor.js:472:23)
    at ImportVisitor.visitDeclaration (/projectfolder/node_modules/@swc/core/Visitor.js:404:29)
    at ImportVisitor.visitStatement (/projectfolder/node_modules/@swc/core/Visitor.js:235:29)
    at ImportVisitor.visitModuleItem (/projectfolder/node_modules/@swc/core/Visitor.js:40:29)

Leubeling avatar Sep 03 '24 10:09 Leubeling

⚠️ No Changeset found

Latest commit: 06bf4cdbed2f7dff7ebd05a93c6706bedba25aec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 03 '24 10:09 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 03 '24 10:09 CLAassistant

CodSpeed Performance Report

Merging #9529 will degrade performances by 7.84%

Comparing Leubeling:fix (06bf4cd) with main (c7fdd6b)

Summary

❌ 1 regressions ✅ 177 untouched benchmarks

:warning: Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main Leubeling:fix Change
es/full/bugs-1 531.7 µs 576.9 µs -7.84%

codspeed-hq[bot] avatar Sep 03 '24 12:09 codspeed-hq[bot]

Closing as stale

kdy1 avatar Jul 01 '25 20:07 kdy1