swc
swc copied to clipboard
refactor(swc_common): replace `Option<Vec<Comment>>` in `Vec<Comment>`
Closes #10531
⚠️ No Changeset found
Latest commit: 395e76ff82438115b2c400ad6fab91de2e7611b9
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
I am sorry for this mistake i have just changed my os and i started using sharkdp dotfiles so i forget to change the name
CodSpeed Performance Report
Merging #10591 will degrade performances by 4.55%
Comparing CodeMan62:codeman/10531 (55eb226) with main (7232c10)
Summary
❌ 7 regressions
✅ 133 untouched benchmarks
:warning: Please fix the performance issues or acknowledge them on CodSpeed.
Benchmarks breakdown
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | babelify-only |
2.1 ms | 2.2 ms | -4.55% |
| ❌ | parse_and_babelify_backbone |
16.7 ms | 17.3 ms | -3.01% |
| ❌ | parse_and_babelify_jquery |
106.2 ms | 109 ms | -2.55% |
| ❌ | parse_and_babelify_jquery_mobile |
180.6 ms | 185.2 ms | -2.5% |
| ❌ | parse_and_babelify_mootools |
78.5 ms | 80.8 ms | -2.88% |
| ❌ | parse_and_babelify_underscore |
14.4 ms | 14.8 ms | -3.01% |
| ❌ | parse_and_babelify_yui |
72.1 ms | 74.2 ms | -2.88% |
we can see there are regressions so should we continue working on it ?
will do a quick refactor and then let you know