swaylock icon indicating copy to clipboard operation
swaylock copied to clipboard

Add possibility to update texts

Open PaulGuerre opened this issue 3 years ago • 10 comments

This pull request allows users to update all the texts, when password is cleared, when caps lock is active, when password is verified and when password is wrong.

PaulGuerre avatar Mar 08 '22 16:03 PaulGuerre

What's the use-case for this?

emersion avatar Mar 08 '22 16:03 emersion

What's the use-case for this?

Just if you want to change the swaylock basic texts. In my case, I don't like the texts without maj : "clear", "wrong". And now, you can have "Clear", "Wrong", or others "key-words" as "Error", or every words.

PaulGuerre avatar Mar 08 '22 16:03 PaulGuerre

This doesn't strike me as a very useful feature.

emersion avatar Mar 08 '22 16:03 emersion

This doesn't strike me as a very useful feature.

I know that some persons (including me) don't like basic texts, especially without first capital letter. That may be used for others languages too.

PaulGuerre avatar Mar 08 '22 17:03 PaulGuerre

I'd be open to capitalize the text FWIW. The lowercase versions aren't a deliberate decision IIRC. Or maybe it's to mimic i3lock? What does i3lock do here?

For translations, I think something like https://github.com/swaywm/swaylock/pull/151 would be a better approach.

emersion avatar Mar 08 '22 17:03 emersion

I'd be open to capitalize the text FWIW. The lowercase versions aren't a deliberate decision IIRC. Or maybe it's to mimic i3lock? What does i3lock do here?

For translations, I think something like #151 would be a better approach.

Ok np, so for thoses like #212 , they may check this repo

PaulGuerre avatar Mar 08 '22 19:03 PaulGuerre

What does i3lock do here?

Capitalize, FWIW: https://github.com/i3/i3lock/blob/4f76d51a3f79082e01b319e9031aad868d89449d/unlock_indicator.c#L218

Xyene avatar Mar 12 '22 00:03 Xyene

I think this would be a useful feature for further customization. Is there any chance of this being merged anytime soon in the future?

NiciTheNici avatar Nov 21 '22 15:11 NiciTheNici

It would be great for other languages. Is there any other way to change English ? Thank you for your work

Elu43 avatar Nov 12 '23 18:11 Elu43